Closed nataled closed 2 years ago
Twitter seems to be rendered already, see https://obofoundry.org/ontology/go
It appears this section of the ontology page template also allows for Google Plus (which doesn't exist anymore IIRC)
Interesting. I'm looking at the GO page, and I do not see that twitter link. Using Firefox on a Windows 10 box, if that matters.
Like @nataled, I'm not seeing it either in Safari on iOS. It may be cross-site blocking on the iframe
.
I followed the instructions at https://publish.twitter.com to make a new one for @news4go
:
<a href="https://twitter.com/news4go?ref_src=twsrc%5Etfw" class="twitter-follow-button" data-show-count="false">Follow @news4go</a><script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>
@cthoyt so you're saying that these links already appear automatically--assuming the right browser is being used--when specified in the YAML file? If so, you should also be able to see that same button when viewing DO.
Thanks @cthoyt. I tried running this locally. That a
element works. (Note that the iframe
also works from localhost.) I think the a
elements is better, but I would remove the ?ref_src=twsrc%5Etfw
. Then the template would be:
<a href="https://twitter.com/{{page.twitter}}" class="twitter-follow-button" data-show-count="false">Follow @{{page.twitter}}</a><script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>
I'm not a Twitter user, so take this with a grain of salt, but I would find a link like https://twitter.com/news4go more useful, rather than a "follow" button.
Edit: data-show-count="true"
shows the number of followers (at least when I test locally), which the iframe
is also showing.
Don't forget that this issue is for more than just twitter. ;)
@cthoyt so you're saying that these links already appear automatically--assuming the right browser is being used--when specified in the YAML file? If so, you should also be able to see that same button when viewing DO.
Indeed this also works for DO, and I'll assume any other ontology that already annotates a twitter account (see screenshot I just took from firefox on my mac)
@jamesaoverton good point - but twitter only generates follow boxes (which actually just link to the page) or mention boxes that create a new tweet when you navigate through it. The current configuration does what's expected.
@nataled I didn't forget this is more general, so I only referenced this issue from the PR instead of saying it closes it.
Follow-up question barrage for @nataled:
@cthoyt I don't know the answers to any of these questions, unfortunately. I just happened to notice that there were links indicated in the YAML files when I was looking for an example of something completely unrelated and, realizing that these weren't visible (at least to me), thought it would be a good idea for them to be so. I haven't done a complete accounting of all possible social media links, nor checked to see how many ontologies use them. My thinking was that these were already 'canon' (so to speak) since they appeared in the YAML.
I wasn't thinking about GitHub repos since we already have visible links to trackers.
I think a social link to "star a repo" would be nice.
In my opinion, no other social sites are used (twitter, facebook).
@cthoyt let me know when you feel like this is ready for final review.
this ticket is too open-ended. We should open more specific, more targeted issues if needed.
I see that the YAML files for a number of ontologies have, in addition to tracker specification, links to various types of social media (twitter, facebook, potentially others). These links are currently not displayed on the Foundry web site. I propose that:
and at least DO does the same.