search

OBOFoundry / OBOFoundry.github.io

Metadata and website for the Open Bio Ontologies Foundry Ontology Registry
http://obofoundry.org
Other
166 stars 204 forks source link

Deselecting only "Hide Obsolete" doesn't show obsolete ontologies #2078

Closed nlharris closed 2 years ago

nlharris commented 2 years ago

The new obofoundry.org ontology table is super-awesome and I love it. I just wanted to report a minor issue I observed with the "Hide Obsolete" button. A good test case is choosing "environment" as the domain; it has one inactive and one obsolete ontology.

By default, both inactive and obsolete ontologies are hidden. If you uncheck "Hide Obsolete", the obsolete ontology does not appear (first screenshot). If, however, you uncheck "Hide Inactive", the inactive ontology appears; if you also have Hide Obsolete unchecked, the obsolete one appears as well (second screenshot).

So "Hide Inactive" appears to be working correctly but "Hide Obsolete" doesn't...unless (this just occurred to me) you consider ALL obsolete ontologies to also be inactive. Maybe that is in fact the case, but the behavior is non-obvious (to me, anyway).

Screen Shot 2022-09-01 at 2 09 52 PM Screen Shot 2022-09-01 at 2 10 01 PM
matentzn commented 2 years ago

All obsolete ontologies are indeed inactive. It seems like there is no real case for having hide obsolete Switched off and hide inactive checked. There is a case for the converse though. Any idea how to improve this?

nlharris commented 2 years ago

Would it be hard to make "hide inactive" acquire a checkbox when you check "hide obsolete"?

nlharris commented 2 years ago

Or did we decide this isn't a logically valid thing to do?