OBOFoundry / OBOFoundry.github.io

Metadata and website for the Open Bio Ontologies Foundry Ontology Registry
http://obofoundry.org
Other
164 stars 201 forks source link

Request for new ontology [COVID-19 Epidemiology and Monitoring Ontology] #2332

Closed NuriaQueralt closed 1 year ago

NuriaQueralt commented 1 year ago

Title

COVID-19 Epidemiology and Monitoring Ontology

Short Description

The COVID-19 Epidemiology and Monitoring Ontology (CEMO) provides a model for describing, sharing and integrating of COVID-19 epidemiological data for outbreak monitoring and research.

Description

The COVID-19 Epidemiology and Monitoring Ontology (CEMO) is designed to make epidemiological quantitative data for monitoring the COVID-19 outbreak machine-readable and interoperable to facilitate its exchange, integration and analysis, to eventually support evidence-based rapid response. This ontology has built following knowledge-engineering standards and the OBO principles to bridge epidemiology into the semantic landscape of the biomedical sciences.

CEMO is designed to be an OBO ontology, i.e., founded on the BFO hierarchy. The taxonomic structure is mainly extended with IDO, a core ontology for infectious diseases, STATO, and APOLLO_SV for epidemiology OBO ontologies terms necessary for epidemiology surveillance. The ontology is built in OWL 2, a DL-based formalism and semantic web standard for knowledge representation to enable data sharing and logic reasoning.

Our formal modeling followed a rationale already used in other studies: 1) determine the domain and scope of the ontology; 2) ontology reuse and addressing poor ontological coverage of COVID-19 epidemiology; and 3) development of a conceptual model for quantitative epidemiological terms. The potential users of the ontology are epidemiological and biomedical researchers.

Identifier Space

CEMO

License

CC0

Domain

health

Source Code Repository

https://github.com/NuriaQueralt/covid19-epidemiology-ontology

Homepage

https://github.com/NuriaQueralt/covid19-epidemiology-ontology

Issue Tracker

https://github.com/NuriaQueralt/covid19-epidemiology-ontology/issues

Contribution Guidelines

https://github.com/NuriaQueralt/covid19-epidemiology-ontology#i-want-to-contribute

Ontology Download Link

https://github.com/NuriaQueralt/covid19-epidemiology-ontology/blob/main/owl/cemo.owl

Contact Name

Núria Queralt Rosinach

Contact Email

nuria.q.rosinach@gmail.com

Contact GitHub Username

NuriaQueralt

Contact ORCID Identifier

0000-0003-0169-8159

Formats

Dependencies

Related

Usages

No response

Intended Use Cases and/or Related Projects

To enable to enable the publication of aggregated health data and federated analysis on sensitive health data for projects such as VODAN.

Data Sources

We reviewed among other sources:

Please see more details here.

Additional comments or remarks

Note that CEMO is currently under development and subject to change.

OBO Foundry Pre-registration Checklist

cmungall commented 1 year ago

I notice that your ontology injects a lot of axioms into existing ontologies:

OBO operations has not yet achieved consensus on best practices for axiom injection (#1443), so my comments do not reflect official OBO views. In the past this has caused a lot of issues as it is easy to arrive at a situation with conflicts.

For example, you inject APOLLO_SV:00000569 under BFO quality, but this conflicts with what is in APOLLO_SV:

image

so merging these ontologies results in a conflict:

robot merge -i cemo.owl -I $OBO/apollo_sv.owl reason -r elk
2023-03-22 14:40:22,622 ERROR org.obolibrary.robot.ReasonerHelper - There are 23 unsatisfiable classes in the ontology.
2023-03-22 14:40:22,627 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/apollo_sv/dev/apollo_sv.owl#APOLLO_SV_00000002
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/apollo_sv/dev/apollo_sv.owl#APOLLO_SV_00000001
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/apollo_sv/dev/apollo_sv.owl#APOLLO_SV_00000003
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000449
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000568
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000569
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/CEMO_0000064
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/IDO_0000519
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000002
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/STATO_0000088
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000140
2023-03-22 14:40:22,628 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000382
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000163
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000383
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/STATO_0000245
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/IDO_0001343
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000381
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000016
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000277
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000497
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/APOLLO_SV_00000498
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/STATO_0000134
2023-03-22 14:40:22,630 ERROR org.obolibrary.robot.ReasonerHelper -     unsatisfiable: http://purl.obolibrary.org/obo/STATO_0000233

I would recommend that you have transparent (i.e github issue) bilateral discussions with the relevant ontologies where if you either disagree with their placement or want to otherwise inject there is clear ongoing discussion about this.

I note you have also injected an axiom subClassOf 'quality of' some 'spatial region' into IDO infection incidence rate. This is a pretty odd axiom, it didn't seem to original with IDO, and it will also cause inference issues.

I also note that that many of your terms seem out of scope for a covid ontology. What happens if say apollo sv or IDO or another ontology wants to add a term "infection fatality rate"? Are they obliged to check all ontologies in OBO including CEMO? What is the SOP if it is determined it is in scope for apollo_sv? Is the term adopted or is the CEMO term obsoleted and replaced by an apollo_sv term?

I want to be clear to other members of OBO-operations here: the problems I note are prevalent with many other OBO ontologies, so I don't think CEMO should be held to a different standard. But I want to underscore the importance of other members of OBO being supportive of proactively solving some of these issues

linikujp commented 1 year ago

I agree that CEMO's focus on COVID-19 can be seen as a use case of epidemiological and monitoring ontology in COVID-19. @NuriaQueralt Can we change the name to Community or Common Epidemiology and Monitoring Ontology? You could keep the CEMO, but transform it to a broader sense. I am the part of the team of this ontology. I agree that @cmungall comments make sense. We'd like to reserve the namespace CEMO while we are reaching out other ontologies and coordinate.

pfabry commented 1 year ago

Hi @NuriaQueralt,

Thank you for your submission. The review for new ontologies will be executed as a two stage process.

You will be informed once your ontology is loaded in the OBO NOR Dashboard. All communications should take place in the present issue.

I see that you have already reserved the namespace with Bioregistry. Please let me know if you want to postpone your submission to the NOR dahsboard considering the issues raised above.

NuriaQueralt commented 1 year ago

Hi @cmungall @linikujp @pfabry,

Thank you very much for your fast feedback.

@cmungall your analysis is super useful! we are currently drafting a more accurate modelling of domain knowledge that have already addressed some of these logical inconsistencies. When finished, we think that will resolve them.

@linikujp this is a great idea and we support it.

@pfabry I am asking the CEMO team about postponing our submission to the NOR dashboard. I will get back to you asap. A question, what happens if our ontology fails to pass some points? will we have the chance to address them and try again?

pfabry commented 1 year ago

A question, what happens if our ontology fails to pass some points? will we have the chance to address them and try again?

Yes, of course :) It's more a back and forth process whose purpose is to ensure an ontology follows OBO foundry's principles.

NuriaQueralt commented 1 year ago

Hi @pfabry

We would like to postpone our submission to the NOR dahsboard considering the issues raised above. How should I proceed once we address the issues and feel ready to restart the submission?

pfabry commented 1 year ago

Hi @NuriaQueralt

I would advise you to close this issue and open a new one once you're ready.

NuriaQueralt commented 1 year ago

Hi @pfabry ,

Thank you very much!

pfabry commented 1 year ago

Feel free to reopen this issue or create a new one when you are ready to submit.