OBOFoundry / purl.obolibrary.org

A system for managing OBO PURLs
BSD 3-Clause "New" or "Revised" License
75 stars 128 forks source link

Update OHD PURL info #873

Closed wdduncan closed 1 year ago

wdduncan commented 1 year ago

Fixes https://github.com/OBOFoundry/purl.obolibrary.org/issues/872

wdduncan commented 1 year ago

@matentzn @jamesaoverton @alanruttenberg I hope I haven't made of things. I keep getting errors like the following:

In file: config/ohd.yml:
{'prefix': '/about/', 'replacement': 'https://ontobee.org/ontology/OHD?iri=http://purl.obolibrary.org/obo/'} is not of type 'string'

Failed validating 'type' in schema['properties']['example_terms']['items']:
    {'type': 'string'}

On instance['example_terms'][1]:
    {'prefix': '/about/',
     'replacement': 'https://ontobee.org/ontology/OHD?iri=http://purl.obolibrary.org/obo/'}
make: *** [Makefile:92: build] Error 1

I'm confused. I thought yaml defaulted to using string datatype. I even tried explicitly putting the term in quotes and got the same error.

I must be missing something simple ... sorry ... but I'm quite confused now, and I'm giving up :(

wdduncan commented 1 year ago

PR is passing now.
Looks like I accidentally deleted the entries key.

matentzn commented 1 year ago

Just for your own safety I recommend to let @jamesaoverton do the merging of updates to PURL configs. I at least do not dare to do it without a review, thinks break easily :)

wdduncan commented 1 year ago

Thanks @matentzn