OBOFoundry / purl.obolibrary.org

A system for managing OBO PURLs
BSD 3-Clause "New" or "Revised" License
75 stars 128 forks source link

Update swo.yml #875

Closed allysonlister closed 1 year ago

allysonlister commented 1 year ago

As a consequence of the update of the repo to build using the ODK.

jamesaoverton commented 1 year ago

The first two changes are fine, but are you sure that you want to remove the last prefix: / entry? The goal is to keep PURLs working. Is this rule not used for anything?

allysonlister commented 1 year ago

Thanks James! Perhaps you can help me a little here. I was comparing the swo file to the new t4fs and thought that perhaps this last bit was unnecessary as the t4fs doesn't have it. I think I was hasty in making the change rather than asking about it. 😉 What does this last bit of the file do?

jamesaoverton commented 1 year ago

The prefix: / rule is a catch-all that will match any path under http://purl.obolibrary.org/obo/swo/ (that was not already matched by a previous rule). Many projects use these catch-alls as the last rule in their PURL config, but then we need more information to know if the rule is actually being used for a legitimate PURL.

To be on the safe side, I suggest that rules should never removed from your PURL configuration file. So I would leave the prefix: / rule in place.

allysonlister commented 1 year ago

Thank you - I have reinstated this - I appreciate the help!