search

OBOFoundry / purl.obolibrary.org

A system for managing OBO PURLs
BSD 3-Clause "New" or "Revised" License
75 stars 128 forks source link

New term redirect bounces are ugly #89

Open jamesaoverton opened 8 years ago

jamesaoverton commented 8 years ago

Example:

  1. GET http://purl.obolibrary.org/obo/ARG_2000379
  2. 302 http://purl.oclc.org/obo/ARG_2000379
  3. 302 http://www.berkeleybop.org/ontologies/ARG_2000379
  4. 302 http://purl.obolibrary.org/obo/ARG/about/ARG_2000379
  5. 404 http://purl.oclc.org/obo/ARG/about/ARG_2000379

Can we short-circuit this with a new failover rule @cmungall ?

- regex: ^/obo/([A-Za-z0-9]+)_(\d+)$
  replacement: http://purl.oclc.org/obo/$1/about/$1_$2

Note that the case is not changed for the first $1. That shouldn't matter since PURL.org is case insensitive. Not sure how to do that with RedirectMatch, but there are heavier ways if needed.

cmungall commented 8 years ago

OK, so we're abandoning the whole /obo/$IDSPACE/about/$FRAGMENT system in the new system, all custom browser changes are made in obo.yml, as specified in the README?

In that case shouldn't the fall through simply be 404?

(aside: I predict about half the ontologies will want to switch to either a custom browser or the new OLS, potentially meaning a lot of churn in obo.yml)

jamesaoverton commented 8 years ago

Half of our projects have an /about/ entry, but half don't.

There are lots of non-numeric IDs that I don't want to 404, e.g. #88.

Regarding your aside: We have some code to handle term_browser: ontobee, and we can write some new code for term_browser: ols, so I don't see a problem there.