search

OBOFoundry / purl.obolibrary.org

A system for managing OBO PURLs
BSD 3-Clause "New" or "Revised" License
75 stars 128 forks source link

Updating cl.yml redirects #890

Closed shawntanzk closed 1 year ago

shawntanzk commented 1 year ago

@anitacaron could you help me make sure these redirects are correctly changed please? :) thanks

shawntanzk commented 1 year ago

hold off merging till we make sure cl-plus can be uploaded to a release

shawntanzk commented 1 year ago

cl-plus can be uploaded to release, and we are on the way to making the release tomorrow (hopefully), probably best not to merge until that is done, but otherwise this is ready for review

jamesaoverton commented 1 year ago

@matentzn No, the exact entries are not redundant. The products entries control the "top-level" space under http://purl.obolibrary.org/obo/ and are highly restricted, while the exact entries control the "project space" under http://purl.obolibrary.org/obo/cl/ and are nearly unrestricted.

matentzn commented 1 year ago

@jamesaoverton I never knew that! Good to know :) Thanks for the clarification.

shawntanzk commented 1 year ago

Think I fixed it, thanks @jamesaoverton & @matentzn

shawntanzk commented 1 year ago

oh yeah, it needs this to be merged first: https://github.com/obophenotype/cell-ontology/pull/1767 didn't know which order it should be in so was hoping to get approval and then merge them both together.

jamesaoverton commented 1 year ago

My understanding of that PR is that you're currently storing the release OWL files in git, but you're going to start attaching them to GitHub releases instead. So there's a synchronization problem. I see two options:

First, if you're not worried about downtime, then coordinate with me or @matentzn to merge this right after CL #1767.

Second, to avoid downtime and be more cautions, do this in three steps:

  1. change the PURL config to point to the 2022-12-15 OWL files in git
  2. merge CL #1767 and attach OWL files to the release
  3. change the PURL config to point to the files attached to the GitHub release
shawntanzk commented 1 year ago

Sorry forgot to reply here, I think a bit of downtime is not a huge deal, I'll wait for https://github.com/obophenotype/cell-ontology/pull/1767 to be merged first, once that is done, I'll ping here and get this reviewed and merged :) thanks heaps

shawntanzk commented 1 year ago

@jamesaoverton I've changed CL release and the links should resolve now, would you mind helping me give a thumbs up if all is good? Thanks

shawntanzk commented 1 year ago

Thanks for doing this so fast @jamesaoverton! really appreciate it :)

jamesaoverton commented 1 year ago

Yes, it looks good. I'll merge now, so the PURLs will be updated in < 20 minutes. You can make further changes if needed.