search

OBOFoundry / purl.obolibrary.org

A system for managing OBO PURLs
BSD 3-Clause "New" or "Revised" License
75 stars 128 forks source link

Change default OLS viewer to OLS4 #922

Closed matentzn closed 1 year ago

matentzn commented 1 year ago

fixes #920

Blocked by

jamesaoverton commented 1 year ago

The double percent signs are important, because this string is being run through Python string formatting, which also uses percent signs (%s). I guess we could switch to Python f-strings for better readability.

This line in the tests will also need to be updated: https://github.com/OBOFoundry/purl.obolibrary.org/blob/d0f91672fe5d42d53d8074eb3dfc97035bb001ab/tools/test.py#L179

matentzn commented 1 year ago

@lschriml @allysonlister and Robert Thacker have confirmed, @dosumis not (but I know he wants this).

@mcourtot I am also sure will agree, so I will take the blame for that. Remains the blocking OLS issue above!

mcourtot commented 1 year ago

Didn't realize this was pending confirmation - all good to me, thank you!

matentzn commented 1 year ago

Ok last problem, no idea whats that about: https://github.com/OBOFoundry/purl.obolibrary.org/actions/runs/5424480866/jobs/9863896909?pr=922

Seems that the OLS PURL send back a HTTP 303. @serjoshua @udp - any idea why that is? If you click on the URLs they resolve, albeit a bit indirectly and slowly..

jamesaoverton commented 1 year ago

Don't worry about the fact that the code is "303". There was a decision many years ago to use "303 See Other" for term IRIs.

The problem is that the expected and actual URLs aren't matching up. Not sure why.