OC-Bandung / birms-html

0 stars 0 forks source link

contract - fields #16

Open mireille-raad opened 6 years ago

mireille-raad commented 6 years ago

We tried to do data statistics before to inform oc-explorer but we couldn't. Now that we have the OCDS json published, here are my questions about fields. I could mine the api, but that might be un-necessary load on the server ;p @bdgcoder feel free to answer things in the comments. Each checkbox item is one question. Sometimes it is long because I try to give description and detail.

Common

Parties

Planning - ocds link

Milestone - ocds link

The current json that you have for milestone is as follow:

 {
     "id": 102,
      "title": "PENGUMUMAN_LELANG",
      "description": null,
       "dueDate": "2016-02-29T23:00:00+00:00",
        "dateMet": "2016-02-24T08:00:00+00:00",
       "status": "scheduled"
  }

In OCDS there is a field called code. Here is the definition: Milestone codes can be used to track specific events that take place for a particular kind of contracting process. For example, a code of ‘approvalLetter’ could be used to allow applications to understand this milestone represents the date an approvalLetter is due or signed. Milestone codes is an open codelist, and codes should be agreed among data producers and the applications using that data.

In the contract page, we this timeline that is supposed to have the following dates:

Old screenshot:

screen shot 2018-08-01 at 12 35 57 pm

So, titan, for the milestones above, can you add a new field called code, and put in it the default value "timeline"?

The above json will become

 {
     "id": 102,
      "title": "HPS Issued In bahasa",
      "code": "timeline", 
      "description": null,
      "dueDate": "2016-02-29T23:00:00+00:00",
       "dateMet": "2016-02-24T08:00:00+00:00",
       "status": "scheduled"
  }

I use the code: timeline to filter what I should show in the UI.

mireille-raad commented 6 years ago

Here are my notes about status:

So, can we maybe un-comment
//$tender->status=$tleresults[0]->stat; //TODO: uncomment this after mapping done

Do we need to add status anywhere else?

For the UI, since we have status enough times, I will leave it there and just add if condition for the times it is not showing.

mireille-raad commented 6 years ago

Here are my notes about Rationale:

It doesn't seem to be in the code. I did a search a quick search. I think it is ta_sasaran (Ur_Sasaran) in the database.

@bdgcoder do you think you will have time to add it? or do i drop it from the UI?

mireille-raad commented 6 years ago