search

OCA / OpenUpgrade

Open source upgrade path for Odoo/OpenERP
https://oca.github.io/OpenUpgrade/
GNU Affero General Public License v3.0
721 stars 690 forks source link

[Discuss] patch distribution of OU #1667

Closed lina2358 closed 5 years ago

lina2358 commented 5 years ago

We have had promising results with maintaining a patch distribution (see branches) of Odoo with the help of some special purpose git tooling.

Given the case that OU could be distributed as a set of patches, it would be easier to adopt in custom code bases.

pedrobaeza commented 5 years ago

I don't get the advantages of that. It's more difficult to maintain and no need to be adopted by any custom code base IMO. You use OpenUpgrade for migrating between versions, and openupgradelib to make some migration tasks inside same version or in OpenUpgrade. What more do you need?

lina2358 commented 5 years ago

@pedrobaeza thanks for your reply. I see it as an alternative. To me it seems advantageous. I don't understand "no need to be adopted by any custom code base".

What I had in mind: I could do git pull openupgrade compiled/12 and my current code base state would be "topped up" to become an open upgrade one.

As I understood it OU is already a set of patches in reality, it is just not distributed as one.

Am I misunderstanding something?

pedrobaeza commented 5 years ago

Then you are promoting an alternative in this repository?

lina2358 commented 5 years ago

@pedrobaeza I'm not sure if we can speak really of "promoting", it's just an idea I deemed worth sharing and discussing. Of course the idea comes with a line of thought, and but not with an agenda.

pedrobaeza commented 5 years ago

Then please propose specific actions to do in current repository, and we can discuss.

lina2358 commented 5 years ago

@pedrobaeza: How would proposal "rebase and connect to Odoo git history" sound like? After all I think that's all that's needed to support the proposed use case.

Or is that already the case? It's not obvious as this repository is not a fork of Odoo.

pedrobaeza commented 5 years ago

We do this regularly, but on OpenUpgrade itself, see for example: https://github.com/OCA/OpenUpgrade/pull/1621

lina2358 commented 5 years ago

@pedrobaeza Almost. You merge upstream odoo. You don't rebase Openupgrade patches upon upstream Odoo. If so, it would be trivial to apply OU on a custom code base. Or do I misunderstand something?

lina2358 commented 5 years ago

Also, I have to note that using git rerere (and share it among maintainers) makes conflict resolution orthogonal to irrelevant code changes. It is an extremely streamlined workflow. And if something breaks you would be auto hinted by a rerere breakage. Different aspects of the OU can be maintained on different topic branches (modularity) and compiled into a synthetic distro branch aka compiled/12

pedrobaeza commented 5 years ago

@acl2358 you are starting to sound more and more like @blaggacao, not being understandable and going to abstract concepts that no one except you want and understand. Several points from what I think I understand:

blaggacao commented 5 years ago

@pedrobaeza Hehe, might be because we have a chance to discuss things in person, but it seems still to be the most effective means of communication, indeed.

If you want to stop this discussion, please just say it. I feel frases convoking majority pressure assumptions like "no one except you" are neither a fair or nor efficient way to convert this into a fruitful discussion.

If an argument is not clear for me, then I might want to refrain as much as I can from forming a canned opinion.

How does your answer relate to providing a patch branch to distribute OU?

I think, materially, it's a completely ortogonal answer.

I feel again and again that any (interesting) discussion gets cloaked in an "opinion filter bubble". 😔

pedrobaeza commented 5 years ago

@blaggacao I'm giving you facts for saying that I don't see this interesting, and I'm not the only one that doesn't understand your arguments as he recently told to you directly, so if 2 of the most prominent maintainers of this project says something similar, and the rest even don't waste time answering, don't you think this is more than an opinion filter bubble?

As I have tried other times to transmit to you, this is not something personal, on contrary as you have expressed to my person in Twitter, only that it's not needed to reinvent the wheel each time, as you pretend to do since you arrived in the Odoo ecosystem. You can have great ideas - you have already contributed with some of them very good -, but that ideas should be very well guided for leading to a "material goal", so I repeat my advises that I gave you in other issue for achieving something in an open source community:

blaggacao commented 5 years ago

I understand everything you say and I've to say I appreciate it.

If you (or anybody) sometimes ask yourself: What is this guy up to?

The answer is: I'm just projecting my vision, not power. (So nobody ought to feel offended)

I hope for this vision to gain traction and power and finally materialize to the benefit who might want to rejoice it. And I honestly have little compassion for the merits of meritocracy. It seems like with vitamins/poisons: