search

OCA / OpenUpgrade

Open source upgrade path for Odoo/OpenERP
https://oca.github.io/OpenUpgrade/
GNU Affero General Public License v3.0
745 stars 697 forks source link

[WIP]MassMailing keep invalid domains in its table, opt_out invalied #3014

Closed flotho closed 1 year ago

flotho commented 2 years ago

Module

mass_mailing

Describe the bug

on v14 image

To Reproduce

migrate from 10 ->14

Affected versions: v14 once migrated

Expected behavior change the domain or recompute legal doamin

pedrobaeza commented 2 years ago

That's barely impossible, as there are tons of possible fields that disappear or are renamed. One possible thing is that you tackle specific cases that are common like the opt_out one, that was introduced in every domain of mass mailing, but I remember that I introduced already some code for that.

Another possible option is to handle renaming of fields in the rename_fields method, querying if mass_mailing is installed (through the existence of the corresponding table), and then looking on the field, but the table name is different across versions, so this gets complicated.

pedrobaeza commented 1 year ago

Closing as stalled.