[16.0][MIG] pos_analytic_by_config: Migration to 16.0

[chienandalu]

WIP: Refactor to adapt to the new analytic distributions approach wich would lead to simpler code:

• New pos_config_id criteria in the analytic distribution model so we can add that weight.
• We can prefix the account so only sales go to that distribution and use a miscellaneous applicability domain in the plan
• With those two changes, we can already set the distributions in our PoS sales.

TODO:

• [x] Check invoicing from process
• [x] Redact readme
• [x] Refactor tests
• [x] Migration scripts

please check @pedrobaeza @victoralmau

@Tecnativa TT45177

[chienandalu]

Tests are failing on product_analytic which I think isn't needed having the analytic distribution applicability criterias for product and product category.

I added a commit to ensure the compatibility of both of them

[chienandalu]

Ready for review

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[pedrobaeza]

/ocabot migration pos_analytic_by_config

[chienandalu]

I agree with this new way of doing this, i started yesterday to continue your pr, but instead of using _generate_pos_order_invoice to inject the context i used _create_invoice.

Yes, _generate_pos_order_invoice is also involved in the generation of other associated moves that (I'm not really not sure about it) could be interesting to filter in a distribution for someone

[pedrobaeza]

/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-610-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

@pedrobaeza The merge process could not be finalized, because command twine check odoo_addon_pos_analytic_by_config-16.0.1.0.0.1-py3-none-any.whl failed with output:

Checking odoo_addon_pos_analytic_by_config-16.0.1.0.0.1-py3-none-any.whl: FAILED
ERROR    `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line : Error: Anonymous hyperlink mismatch: 1 references but 0 targets.
         See "backrefs" attribute for IDs.                                      
WARNING  `long_description_content_type` missing. defaulting to `text/x-rst`.   

[pedrobaeza]

@chienandalu it seems the conversion from MD to RST didn't go well. Please check the texts.

[chienandalu]

Let's try again

[pedrobaeza]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-610-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

@pedrobaeza The merge process could not be finalized, because command twine check odoo_addon_pos_analytic_by_config-16.0.1.0.0.1-py3-none-any.whl failed with output:

Checking odoo_addon_pos_analytic_by_config-16.0.1.0.0.1-py3-none-any.whl: FAILED
ERROR    `long_description` has syntax errors in markup and would not be        
         rendered on PyPI.                                                      
         line : Error: Anonymous hyperlink mismatch: 1 references but 0 targets.
         See "backrefs" attribute for IDs.                                      
WARNING  `long_description_content_type` missing. defaulting to `text/x-rst`.   

[pedrobaeza]

Still the same... Not sure which is the problem. Maybe you should keep it as RST.

[chienandalu]

Let's try again

[pedrobaeza]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-610-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at bdfa45b1498a0cb0fbf40470f7b5b5d80d5870e7. Thanks a lot for contributing to OCA. ❤️