Closed AungKoKoLin1997 closed 1 month ago
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
Is it perhaps the case that this is the same issue that is solved in the 17.0 migration using _get_custom_move_fields
? See https://github.com/OCA/account-analytic/pull/614/commits/fa50c404e9a89e43bb5ea1c65a9ff1166180cde5, included in https://github.com/OCA/account-analytic/pull/614). If so, isn't using that entry point more appropriate?
Is it perhaps the case that this is the same issue that is solved in the 17.0 migration using
_get_custom_move_fields
? See fa50c40, included in #614). If so, isn't using that entry point more appropriate?
Thanks! The suggested approach does look better indeed. @AungKoKoLin1997
@AungKoKoLin1997 thanks for the update! Can you credit @aisopuro as a co-author of the commit? (see https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line)
/ocabot merge patch
What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-641-by-StefanRijnhart-bump-patch, awaiting test results.
Congratulations, your PR was merged at 24ef217f302b7e731169361a2868884b440df2ca. Thanks a lot for contributing to OCA. ❤️
@qrtl QT4346