search

OCA / account-analytic

Odoo Account Analytic Related Addons
GNU Affero General Public License v3.0
101 stars 358 forks source link

[16.0][FIX] stock_analytic: use standard method to get stock valuation account #665

Closed tli-asl closed 2 weeks ago

tli-asl commented 2 months ago

This commit fixes the direct access to the value of property_stock_valuation_account_id defined in the product category of the product of the move. This commit gets the account using the get_product_accounts() method to improve inheritability and consistency with the standard code base.

tli-asl commented 2 months ago

Hi all,

As this is my very first OCA PR, I don't know who to ping. I checked the last PR's, and it seems you, @pedrobaeza @dreispt, are really pro-active, would it be possible to review this one ?

Your comments will be more than welcome !

Thanks in advance !

Cc: @iaj-asl @it-ideas

pedrobaeza commented 2 months ago

The authors/maintainers of the module may review it. You can review other PRs and ask in exchange that they review yours.

IT-Ideas commented 2 months ago

Hey @tli-asl 👋 Good to see you here 🤩

OCA-git-bot commented 2 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dreispt commented 2 weeks ago

/ocabot merge patch

OCA-git-bot commented 2 weeks ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-665-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot commented 2 weeks ago

Congratulations, your PR was merged at 3d9aaac435fde6a9389c501f060995f56e088f82. Thanks a lot for contributing to OCA. ❤️