Closed gaelTorrecillas closed 1 week ago
Hi @gaelTorrecillas
thanks for this PR.
First of all, could you please change the PR name and the commit names with a rebase to follow the guidelines https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#git
Then for your re commit issue, could you run pre-commit run --all-files
and commit the result in a dedicated commit for lint
Hi @gaelTorrecillas Thanks for this PR . Codecov is sometimes weird as I discovered with @pedrobaeza My proposal is that you rename your PR and commits following the guidelines and then we'll be able to make a proper review and maybe we'll have better ideas for the codecov regression.
Regards
Hi @gaelTorrecillas thanks, could you change the PR name please?
Hi @gaelTorrecillas, where is the pre-commit commit before migration commit?
Hi @gaelTorrecillas, where is the pre-commit commit before migration commit?
Holidays for @gaelTorrecillas more to come in a few weeks
/ocabot migration analytic_partner
The migration issue (#489) has not been updated to reference the current pull request because a previous pull request (#609) is not closed. Perhaps you should check that there is no duplicate work. CC @dreispt
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-672-by-dreispt-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 3bd2cb6a2eca42022cdc5b8d8904098099f4bddc. Thanks a lot for contributing to OCA. ❤️
Hi,
I fork this pr https://github.com/OCA/account-analytic/pull/609 and I add all your recommendations.