OCA / account-analytic

Odoo Account Analytic Related Addons
GNU Affero General Public License v3.0
101 stars 358 forks source link

[16.0] [MIG] analytic_partner #672

Closed gaelTorrecillas closed 1 week ago

gaelTorrecillas commented 1 month ago

Hi,

I fork this pr https://github.com/OCA/account-analytic/pull/609 and I add all your recommendations.

flotho commented 1 month ago

Hi @gaelTorrecillas thanks for this PR. First of all, could you please change the PR name and the commit names with a rebase to follow the guidelines https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#git Then for your re commit issue, could you run pre-commit run --all-files and commit the result in a dedicated commit for lint

flotho commented 1 month ago

Hi @gaelTorrecillas Thanks for this PR . Codecov is sometimes weird as I discovered with @pedrobaeza My proposal is that you rename your PR and commits following the guidelines and then we'll be able to make a proper review and maybe we'll have better ideas for the codecov regression.

Regards

flotho commented 1 month ago

Hi @gaelTorrecillas thanks, could you change the PR name please?

peluko00 commented 1 month ago

Hi @gaelTorrecillas, where is the pre-commit commit before migration commit?

flotho commented 2 weeks ago

Hi @gaelTorrecillas, where is the pre-commit commit before migration commit?

Holidays for @gaelTorrecillas more to come in a few weeks

rafaelbn commented 1 week ago

/ocabot migration analytic_partner

OCA-git-bot commented 1 week ago

The migration issue (#489) has not been updated to reference the current pull request because a previous pull request (#609) is not closed. Perhaps you should check that there is no duplicate work. CC @dreispt

dreispt commented 1 week ago

/ocabot merge nobump

OCA-git-bot commented 1 week ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-672-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot commented 1 week ago

Congratulations, your PR was merged at 3bd2cb6a2eca42022cdc5b8d8904098099f4bddc. Thanks a lot for contributing to OCA. ❤️