search

OCA / account-budgeting

38 stars 113 forks source link

[12.0][FIX] account_budget_oca: fix date format in psql query #26

Closed cvinh closed 5 years ago

cvinh commented 5 years ago

Before that fix, we have an error in the query (to_date function does not exist anymore in psql) when we add a budget line and save it

cvinh commented 5 years ago

Hello, on our side we use the PR in production @astripe fell free to override it if you think code should be cleaned up... sorry did not have time to go further on that one

astirpe commented 5 years ago

@cvinh Is not just a matter of cleaning up. After your fix, the part of code I was mentioning (wizard_date_from and wizard_date_to) will be failing if someone use it for some reason.

cvinh commented 5 years ago

I see... let me do that changes... it's not that big

patrickrwilson commented 5 years ago

Thanks @cvinh, I look forward to test and review once you submit the update.

astirpe commented 5 years ago

Can this one be merged?

pedrobaeza commented 5 years ago

Merging blindly according reviews

/ocabot merge patch

OCA-git-bot commented 5 years ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 12.0-ocabot-merge-pr-26-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 5 years ago

Congratulations, your PR was merged at 2f036025a97ed0ae4fac96c7ab502221522da45b. Thanks a lot for contributing to OCA. ❤️