search

OCA / account-budgeting

37 stars 113 forks source link

13.0 mig account budget oca #37

Closed amcor closed 2 years ago

amcor commented 4 years ago

cc @guadaltech

amcor commented 4 years ago

@astirpe thanks for the review !! I think i've done all suggestions.

RachidAlassir commented 4 years ago

@amcor In Accounting -> Management -> budget: After clicking at "Add line" (in Budget lines) This error appears:

  File "/home/.../account/account_budget_oca/models/account_budget.py", line 186, in _compute_theoretical_amount
    line_timedelta = from_string(line.date_to) - from_string(line.date_from)
TypeError: unsupported operand type(s) for -: 'NoneType' and 'NoneType'
flachica commented 3 years ago

@amcor In Accounting -> Management -> budget: After clicking at "Add line" (in Budget lines) This error appears:

  File "/home/.../account/account_budget_oca/models/account_budget.py", line 186, in _compute_theoretical_amount
    line_timedelta = from_string(line.date_to) - from_string(line.date_from)
TypeError: unsupported operand type(s) for -: 'NoneType' and 'NoneType'

I have just performed the operations you describe and the problem does not appear. The dates on the lines are now required. I don't know if when you tested the module they were

OCA-git-bot commented 2 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

unique4 commented 2 years ago

All check passed, why is this PR not merged?

dreispt commented 2 years ago

/ocabot merge nobump

OCA-git-bot commented 2 years ago

This PR looks fantastic, let's merge it! Prepared branch 13.0-ocabot-merge-pr-37-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at f1fd49313a466895d5040b5e4fe78d3abb709c93. Thanks a lot for contributing to OCA. ❤️