search

OCA / account-financial-tools

Odoo Accountant Financial Tools and Utils
GNU Affero General Public License v3.0
302 stars 750 forks source link

Project dependencies may have API risk issues #1483

Closed PyDeps closed 3 months ago

PyDeps commented 1 year ago

Hi, In account-financial-tools, inappropriate dependency versioning constraints can cause risks.

Below are the dependencies and version constraints that the project is using

freezegun
numpy
numpy-financial<=1.0.0
python-dateutil
vatnumber

The version constraint == will introduce the risk of dependency conflicts because the scope of dependencies is too strict. The version constraint No Upper Bound and * will introduce the risk of the missing API Error because the latest version of the dependencies may remove some APIs.

After further analysis, in this project, The version constraint of dependency python-dateutil can be changed to >=2.1,<=2.8.2.

The above modification suggestions can reduce the dependency conflicts as much as possible, and introduce the latest version as much as possible without calling Error in the projects.

The invocation of the current project includes all the following methods.

The calling methods from the python-dateutil 
dateutil.relativedelta.relativedelta

@developer Could please help me check this issue? May I pull a request to fix it? Thank you very much.

github-actions[bot] commented 5 months ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.