search

OCA / account-financial-tools

Odoo Accountant Financial Tools and Utils
GNU Affero General Public License v3.0
305 stars 748 forks source link

[14.0][IMP] account_asset_management, allow manual entry/editing of depreciation board #1733

Open bosd opened 11 months ago

bosd commented 11 months ago

Forward port of https://github.com/OCA/account-financial-tools/pull/1208 continuation of #1237

bosd commented 11 months ago

@Dranyel-Bosd Can you please review?

bosd commented 7 months ago

@etobella Can you please merge?

bosd commented 7 months ago

Improved coverage @etobella it is ready now

OCA-git-bot commented 7 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

bosd commented 6 months ago

ping @JordiBForgeFlow Can you have a look here / merge? 🙏

etobella commented 6 months ago

/ocabot merge patch

etobella commented 6 months ago

Let's proceed with merge in order to avoid delay (we have given enough time)

OCA-git-bot commented 6 months ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-1733-by-etobella-bump-patch, awaiting test results.

OCA-git-bot commented 6 months ago

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1733-by-etobella-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

bosd commented 4 months ago

The depreciation table can already be edited before confirming an asset.

But we cannot edit a running asset. Which is quite common to do in some countries. So, I think we need this.

@JordiBForgeFlow @kittiu What do you think?

JordiBForgeFlow commented 4 months ago

@bosd I also think that we need this.

bosd commented 4 months ago

I'm aborting the merge and check this deeply proposing the implementation today.

@pedrobaeza Which changes would you like to see?

kittiu commented 4 months ago

@bosd IMHO I think the current one that edit before submit is good enough. I think I am too concern with performance when dealing with lots of asset. Will this store false account into it?

If not, I think this can be a good feature.

bosd commented 4 months ago

Update: Changed the fields back to stored.

  • The number of commits is not acceptable.

I have squashed the commits of @JordiBForgeFlow . The other commits I kept in place to retain author ship.

Renamed the commit messages.

bosd commented 4 months ago

@pedrobaeza Is this one ok now?