search

OCA / account-financial-tools

Odoo Accountant Financial Tools and Utils
GNU Affero General Public License v3.0
303 stars 749 forks source link

[16.0][MIG] account_sequence_option: Migration to 16.0 #1775

Open matteoopenf opened 9 months ago

pedrobaeza commented 9 months ago

Please rename PR title as I have told you in the other one.

matteoopenf commented 9 months ago

Please rename PR title as I have told you in the other one.

done

matteoopenf commented 9 months ago

@pedrobaeza or @kittiu have any idea how can fix the test or the compute_name() because we do a lot of try but we don't find a solution

pedrobaeza commented 9 months ago

Sorry, I haven't dug on such module, and in fact, I prefer core solution instead of this.

patrickt-oforce commented 9 months ago

Sorry, I haven't dug on such module, and in fact, I prefer core solution instead of this.

We prefer core solution, too; but some of our customer has a strange sequence format, with progressive number in front and year as suffix; the new heuristic search of Odoo, confuse the year as progressive number and increment that at every new move confirmed. The problem arise because the customer cannot change the sequencing due to italian fiscal rule

pedrobaeza commented 9 months ago

AFAIK, there's a sequence regex you can use for that.

patrickt-oforce commented 9 months ago

AFAIK, there's a sequence regex you can use for that.

Our use case is something similar to /year; what si the regex taht you talk about, can you link the Odoo source?

bhaveshselarka commented 9 months ago

@matteoopenf @patrickt-oforce thanks for migration, any chance to merge this PR ?

matteoopenf commented 9 months ago

For us the migration is ready and we use the module in production.We need only the review  to merge Matteo @. Il giorno 23 nov 2023, alle ore 07:39, bhaveshselarka @.> ha scritto: @matteoopenf @patrickt-oforce thanks for migration, any chance to merge this PR ?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Openforce Srls Unipersonale | www.openforce.it | 02 21119472 | Via Tiziano,32 20145 Milano

matteoopenf commented 9 months ago

@matteoopenf @patrickt-oforce thanks for migration, any chance to merge this PR ?

You can check the code and Run bot and after approve if you agree

Saran440 commented 7 months ago

@matteoopenf Functional Test, this PR is not working. after I add () in my review, it still not working.

I tested by use code v15 it work https://github.com/OCA/account-financial-tools/pull/1635

The problem seems to be related to a conflict between the account_move_name_sequence and account_sequence_option modules. I looking for solution for this.

matteoopenf commented 7 months ago

@matteoopenf Functional Test, this PR is not working. after I add () in my review, it still not working.

I tested by use code v15 it work #1635

The problem seems to be related to a conflict between the account_move_name_sequence and account_sequence_option modules. I looking for solution for this.

thank you

Saran440 commented 7 months ago

It still not working.

Step to error:

  1. install module account and account_sequence_option
  2. active sequence option with demo data
  3. go to Invoicing > Customers > Invoices
  4. create new invoice > Confirm
  5. name still INV/2024/XXXX. it should be CINV/XXXX Selection_010 Selection_011

I created new PR https://github.com/OCA/account-financial-tools/pull/1810 @matteoopenf what do you think?

matteoopenf commented 2 months ago

It still not working.

Step to error:

  1. install module account and account_sequence_option
  2. active sequence option with demo data
  3. go to Invoicing > Customers > Invoices
  4. create new invoice > Confirm
  5. name still INV/2024/XXXX. it should be CINV/XXXX Selection_010 Selection_011

I created new PR #1810 @matteoopenf what do you think?

sorry for my delay Now I check.