search

OCA / account-financial-tools

Odoo Accountant Financial Tools and Utils
GNU Affero General Public License v3.0
303 stars 749 forks source link

[16.0][ADD] stock_account_anglo_saxon_cogs_kit #1791

Closed MarinaAForgeFlow closed 2 weeks ago

MarinaAForgeFlow commented 8 months ago

The Odoo Official documentation recommends to use consumable for kit products and only to be storable in case Anglosaxon accounting:

https://www.odoo.com/documentation/16.0/applications/inventory_and_mrp/manufacturing/management/kit_shipping.html

"Although kits should almost always be set to Consumable, companies using Anglo-Saxon accounting might need to create kits as a Storable Product. This is because when processing invoices for kits, the Cost of Goods Sold (COGS) will be posted in accounting journals."

However, that forces companies to track quantities for kits, and that is not always desirable.

With this module companies using Anglo-Saxon accounting don't need to set the kit products to be storable if they don'e want to track quantities for the kit.

cc @ForgeFlow

AaronHForgeFlow commented 1 month ago

LGTM! just squash commits into one please

OCA-git-bot commented 1 month ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

AaronHForgeFlow commented 1 month ago

This module depends on sale_mrp as the main need is to cover the case for kits consumable. Also added a test.

AaronHForgeFlow commented 2 weeks ago

/ocabot merge nobump

OCA-git-bot commented 2 weeks ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-1791-by-AaronHForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot commented 2 weeks ago

Congratulations, your PR was merged at 8f3a63b6f494193c18aaa0f03145720d89423627. Thanks a lot for contributing to OCA. ❤️