search

OCA / account-financial-tools

Odoo Accountant Financial Tools and Utils
GNU Affero General Public License v3.0
300 stars 741 forks source link

[17.0][MIG] account_asset_management #1819

Closed sbiosca-s73 closed 1 month ago

sbiosca-s73 commented 5 months ago

Migration module account_asset_management to v17.0

sbiosca-s73 commented 4 months ago

@tien-ld changes done!

OCA-git-bot commented 4 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza commented 3 months ago

/ocabot migration account_asset_management

xtanuiha commented 3 months ago

Hello, I have updated the Simplified Chinese translation zh_CN.po; please merge it, thank you!

zh_CN.zip

sbiosca-s73 commented 3 months ago

@tien-ld changes done. @xtanuiha I updated the translation

HaraldPanten commented 2 months ago

@sbiosca-s73 will you continue with this PR?

THX.

sbiosca-s73 commented 1 month ago

@celm1990 changes done, I split commits and deleted the unnecessary file. @xtanuiha done. @HaraldPanten

HaraldPanten commented 1 month ago

@celm1990 changes done, I split commits and deleted the unnecessary file. @xtanuiha done. @HaraldPanten

THX! @sbiosca-s73 Could you check tests?

sbiosca-s73 commented 1 month ago

@HaraldPanten tests checked

OCA-git-bot commented 1 month ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

HaraldPanten commented 1 month ago

Could you separate pre-commit changes from migration commit?

THX.

sbiosca-s73 commented 1 month ago

@HaraldPanten what changes?

HaraldPanten commented 1 month ago

When you open a new PR for a migration, you need to apply pre-commit, right? (black, isort, prettier).

This command makes some changes to your code and they have to be in a separate commit (not in the migration commit).

And then, you start the migration. These changes would be included in a new commit (the migration commit)

Here you can see several examples:

https://github.com/OCA/l10n-spain/pull/3583 https://github.com/OCA/account-invoice-reporting/pull/319

You'll see that the migration PRs that I mentioned have 2 commits. One of them is for the pre-commit stuff.

Maybe @ioans73 can explain you better

pedrobaeza commented 1 month ago

Following https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch is what you obtain.

ioans73 commented 1 month ago

@HaraldPanten @pedrobaeza Thanks for your comments :) I'm going to review it with @sbiosca-s73

sbiosca-s73 commented 1 month ago

@HaraldPanten @pedrobaeza changes done, thanks!

sbiosca-s73 commented 1 month ago

@pedrobaeza changes done

OCA-git-bot commented 1 month ago

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-1819-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at 6a9c3c720999db9d7658f0090d4a89165d758ecf. Thanks a lot for contributing to OCA. ❤️