[FIX] base_vat_optional_vies: change dependency

OCA / account-financial-tools

Odoo Accountant Financial Tools and Utils

GNU Affero General Public License v3.0

300 stars 741 forks source link

[FIX] base_vat_optional_vies: change dependency #1841

Closed yajo closed 3 months ago

yajo commented 3 months ago

This module required vatnumber just to make sure upstream odoo behaved as expected.

However, upstream changed to using stdnum in https://github.com/odoo/odoo/commit/c377e46da1a99fae928269fcf95317a8ca4e88f6, so that's what we should require here now.

Besides, tests were bringing false positives and negatives. Now they test the correct behavior.

@moduon MT-5599

yajo commented 3 months ago

Tests should pass now.

OCA-git-bot commented 3 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 3 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 12.0-ocabot-merge-pr-1841-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 185e142814c75831effb70dfc6954daab5508ff9. Thanks a lot for contributing to OCA. ❤️