search

OCA / account-financial-tools

Odoo Accountant Financial Tools and Utils
GNU Affero General Public License v3.0
300 stars 741 forks source link

[16.0][IMP] account_asset_management: Keep line original price on expansion #1848

Closed aritzolea closed 3 months ago

aritzolea commented 3 months ago

Some modules (account-invoicing repo's account_invoice_pricelist for instance) re-calculate a move line's price unit when quantity is modified.

This brings problems to account_asset_management module when lines are expanded and quantity is set to 1, because line's price value can be lost and set to it's default value.

This modification forces price value not to be lost.

This video shows the problem when these modules are both installed:

https://github.com/OCA/account-financial-tools/assets/31987854/fd26ebd4-e73f-44fe-871a-b78266a3d6e4

OCA-git-bot commented 3 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 3 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-1848-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 3 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 3 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 3 months ago

It looks like something changed on 16.0 in the meantime. Let me try again (no action is required from you). Prepared branch 16.0-ocabot-merge-pr-1848-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 5e1347a4df19153e88afffef21cacba97f4473e5. Thanks a lot for contributing to OCA. ❤️