OCA / account-financial-tools

Odoo Accountant Financial Tools and Utils
GNU Affero General Public License v3.0
298 stars 739 forks source link

[17.0][MIG] account_invoice_constraint_chronology: Migration to 17.0 #1889

Open zuher83 opened 1 month ago

zuher83 commented 1 month ago

I've just migrated this module to version 17.0. But I think this module is incomplete or even dangerous in some cases.

In France, for example, we don't have the right to cancel or delete an invoice! If we're on May 27, 2024 and the accountant creates an invoice dated October 20, 2024 by mistake and validates it, this will systematically block the creation of invoices prior to this date of 10/20/2024. This could have serious consequences for the invoicing process.

Solution 1: Don't allow invoices to be created after today's date

Solution 2: To be more flexible, we can add an "int" field in the accounting journal, allowing invoices to be created after 3, 5 or 10, ... days (depending on the administrator's configuration) from today's date.

In the migration I didn't make any changes to implement this approach, I intended to create a new module inherited from account_invoice_constraint_chronology and implement this very important change! If you agree, I can implement it directly in the account_invoice_constraint_chronology module.

I look forward to hearing from you.

zuher83 commented 1 month ago

I've created an issue #1890 to discuss it! I will implement with a legacy module the ability to block the number of subsequent days allowed to bill at a later date. If you agree, then we can add this functionality to this module.