search

OCA / account-invoicing

Odoo Invoicing Extension Addons
GNU Affero General Public License v3.0
237 stars 683 forks source link

[account_global_discount] Discounts are showed in invoice lines #1765

Open alvaro-domatix opened 2 months ago

alvaro-domatix commented 2 months ago

In version 15.0, when you applied global discounts to invoices, they were not shown in the invoice lines or invoice reports. Now, in version 16.0, they are shown. This may not be a problem for single-line invoices, but it is for invoices with multiple lines.

I would like to know if there is any reason for this change, and if there is not, propose to revert it to the previous behavior. I would appreciate feedback in order to address this issue properly.

In this comment, @rafaelbn shows what I'm trying to explain: https://github.com/OCA/account-invoicing/pull/1338#issuecomment-1664656927

@ferran-S73 @pedrobaeza

Thank you

ferran-S73 commented 2 months ago

I don't recall any specific reason for discount lines to be in the invoice tab. Maybe they should be created with a different display_type. Unfortunately I can't really tell you which type maybe someone with more accounting knowledge can help