Closed urvisha-serpentcs closed 1 year ago
/ocabot rebase
Congratulations, PR rebased to 16.0.
/ocabot migration agreement_legal
Hello @ygol Is it possible to move forward with this?
Besides the PR mentioned above, it would be nice to make the create method work in batch, split the create_agreement function into a method with only the logic and one that does the view stuff (for cleaner overrides, instead of doing self.env[res["res_model"]].browse(res["res_id"])
...).
Also, comment all the settings that refer to modules that haven't been migrated, and other modules depend on this one (e.g. agreement_project).
Hello @ygol Is it possible to move forward with this?
Besides the PR mentioned above, it would be nice to make the create method work in batch, split the create_agreement function into a method with only the logic and one that does the view stuff (for cleaner overrides, instead of doing
self.env[res["res_model"]].browse(res["res_id"])
...).Also, comment all the settings that refer to modules that haven't been migrated, and other modules depend on this one (e.g. agreement_project).
Hi @len-foss I believe this PR was opened by @urvisha-serpentcs . Right?
Right, it seems the work is done so the only thing left is a maintainer review/merge the PR. Did I get something wrong?
Right, it seems the work is done so the only thing left is a maintainer review/merge the PR. Did I get something wrong?
oh no. sorry for the confusion. it just you made some recommendation/remarks in your review and I thought you asked me to address them.
/ocabot rebase
Congratulations, PR rebased to 16.0.
@urvisha-serpentcs Could you just put the version change in manifest.py in migration commit and not in pre-commit one ? Thanks
@JayVora-SerpentCS
@urvisha-serpentcs there are some test cases covered in PR# you can use to increase score.
Honestly the simpler way would be to merge the PR, and then do another PR to bring #9 and/or other fixes.
@rousseldenis do you have merge rights?
Honestly the simpler way would be to merge the PR, and then do another PR to bring #9 and/or other fixes.
@rousseldenis do you have merge rights?
Indeed we can do a further PR
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-8-by-rousseldenis-bump-nobump, awaiting test results.
Thank you!
Congratulations, your PR was merged at 60c97ac011cf0f50efebb6b940baeeed1dc6e381. Thanks a lot for contributing to OCA. ❤️
Can you add the commits from #9 please?