search

OCA / agreement

GNU Affero General Public License v3.0
8 stars 38 forks source link

16.0 mig agreement legal #8

Closed urvisha-serpentcs closed 1 year ago

sanchonuria commented 1 year ago

Can you add the commits from #9 please?

rousseldenis commented 1 year ago

/ocabot rebase

OCA-git-bot commented 1 year ago

Congratulations, PR rebased to 16.0.

rousseldenis commented 1 year ago

/ocabot migration agreement_legal

len-foss commented 1 year ago

Hello @ygol Is it possible to move forward with this?

Besides the PR mentioned above, it would be nice to make the create method work in batch, split the create_agreement function into a method with only the logic and one that does the view stuff (for cleaner overrides, instead of doing self.env[res["res_model"]].browse(res["res_id"])...).

Also, comment all the settings that refer to modules that haven't been migrated, and other modules depend on this one (e.g. agreement_project).

ygol commented 1 year ago

Hello @ygol Is it possible to move forward with this?

Besides the PR mentioned above, it would be nice to make the create method work in batch, split the create_agreement function into a method with only the logic and one that does the view stuff (for cleaner overrides, instead of doing self.env[res["res_model"]].browse(res["res_id"])...).

Also, comment all the settings that refer to modules that haven't been migrated, and other modules depend on this one (e.g. agreement_project).

Hi @len-foss I believe this PR was opened by @urvisha-serpentcs . Right?

len-foss commented 1 year ago

Right, it seems the work is done so the only thing left is a maintainer review/merge the PR. Did I get something wrong?

ygol commented 1 year ago

Right, it seems the work is done so the only thing left is a maintainer review/merge the PR. Did I get something wrong?

oh no. sorry for the confusion. it just you made some recommendation/remarks in your review and I thought you asked me to address them.

rousseldenis commented 1 year ago

/ocabot rebase

OCA-git-bot commented 1 year ago

Congratulations, PR rebased to 16.0.

rousseldenis commented 1 year ago

@urvisha-serpentcs Could you just put the version change in manifest.py in migration commit and not in pre-commit one ? Thanks

rousseldenis commented 1 year ago

@JayVora-SerpentCS

SkiBY commented 1 year ago

@urvisha-serpentcs there are some test cases covered in PR# you can use to increase score.

len-foss commented 1 year ago

Honestly the simpler way would be to merge the PR, and then do another PR to bring #9 and/or other fixes.

@rousseldenis do you have merge rights?

rousseldenis commented 1 year ago

Honestly the simpler way would be to merge the PR, and then do another PR to bring #9 and/or other fixes.

@rousseldenis do you have merge rights?

Indeed we can do a further PR

/ocabot merge nobump

OCA-git-bot commented 1 year ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-8-by-rousseldenis-bump-nobump, awaiting test results.

len-foss commented 1 year ago

Thank you!

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 60c97ac011cf0f50efebb6b940baeeed1dc6e381. Thanks a lot for contributing to OCA. ❤️