search

OCA / bank-payment

Odoo Electronic Payment
https://odoo-community.org/psc-teams/banking-10
GNU Affero General Public License v3.0
198 stars 524 forks source link

[17.0][FIX] account_payment_order: Assure partner bank account in payments #1348

Closed pedrobaeza closed 2 weeks ago

pedrobaeza commented 2 weeks ago

Forward-port of #1346

On certain v16 instances, although the partner bank account that is being pre-set in the account.payment creation values dictionary:

https://github.com/OCA/bank-payment/blob/fc7783669f40d85/account_payment_order/models/account_payment_line.py#L206

it's being marked as dirty (it's a computed writable field), and thus, being recomputed before being saved, getting an invalid value (on direct debits, the company's bank account).

The triggers that lead to this situation are unknown due to the low level where it's happening and the tons of interactions being taken in place, so the best way to deal with this is to override the compute method that computes this value, so even if the field is recomputed, it gets the correct value.

Let's be pragmatic...

@Tecnativa TT50804

pedrobaeza commented 2 weeks ago

/ocabot merge patch

OCA-git-bot commented 2 weeks ago

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-1348-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 2 weeks ago

Congratulations, your PR was merged at 260d47b47db3b17c5cf80c23c5716af1e900014a. Thanks a lot for contributing to OCA. ❤️