search

OCA / bank-payment

Odoo Electronic Payment
https://odoo-community.org/psc-teams/banking-10
GNU Affero General Public License v3.0
198 stars 524 forks source link

Potential lost data on account payment order migration #1363

Open lorenzoallegrucci opened 4 hours ago

lorenzoallegrucci commented 4 hours ago

Module

account_payment_order

Describe the bug

After this commit https://github.com/OCA/bank-payment/commit/4c9020f0eb06dca985bb9e9d32314d10425246b1 account_payment records are not created due for account payment state not in ('uploaded', 'done') loosing data!!

The same problem is on 14->15 migration: https://github.com/OCA/bank-payment/blob/15.0/account_payment_order/migrations/15.0.2.0.0/post-migration.py#L35

To Reproduce

Affected versions:

Steps to reproduce the behavior:

  1. migrate from <= 13.0 to >= 14.0

Expected behavior not loosing data

Additional context Add any other context about the problem here. (e.g. OS, Python version, ...)

lorenzoallegrucci commented 4 hours ago

@etobella can you explain better this critical commit https://github.com/OCA/bank-payment/commit/4c9020f0eb06dca985bb9e9d32314d10425246b1 ? Thank you