OCA / brand

Manage brands for products and companies
GNU Affero General Public License v3.0
48 stars 164 forks source link

Clicking any brand link on the product_template kanban view results in error #190

Closed symbiotech closed 1 month ago

symbiotech commented 9 months ago

Module

product_brand

Describe the bug

Clicking any brand link on the product_template kanban view results in the error bellow:

EvalError: Can not evaluate python expression: ([('product_ids', 'in', id)])
Error: Name 'id' is not defined
    at evaluateExpr (http://45.33.98.35/web/assets/0ddd052/web.assets_web.min.js:3029:54)
    at _preprocessAction (http://45.33.98.35/web/assets/0ddd052/web.assets_web.min.js:10127:150)
    at doAction (http://45.33.98.35/web/assets/0ddd052/web.assets_web.min.js:10209:170)
    at async Object.doActionButton (http://45.33.98.35/web/assets/0ddd052/web.assets_web.min.js:10217:196)
    at async execute (http://45.33.98.35/web/assets/0ddd052/web.assets_web.min.js:9843:293)
    at async executeButtonCallback (http://45.33.98.35/web/assets/0ddd052/web.assets_web.min.js:9836:34)

To Reproduce

Affected versions: Odoo 17

Steps to reproduce the behavior:

  1. Navigate to Products - Products section
  2. Make sure you are on the Kanban view
  3. Click on any product brand link

Expected behavior Action should open a Product Brand page with the filter applied to the selected brand, without throwing an error. Bug seems to have been introduced in this line

symbiotech commented 9 months ago

@thaolt99 can you please take a look at this issue and the related pull request?

github-actions[bot] commented 3 months ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.