search

OCA / business-requirement

Business Requirements Management via Odoo
GNU Affero General Public License v3.0
65 stars 153 forks source link

[FIX] business_requirement_deliverable: Count unpublished deliverables in portal #343

Closed sergio-teruel closed 3 years ago

sergio-teruel commented 3 years ago

cc @Tecnativa ping @CarlosRoca13 @victoralmau

OCA-git-bot commented 3 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sergio-teruel commented 3 years ago

Why have I done this? For one business requirement (BR) published in portal you can published all BR deliveries or any, so in BR portal view we van not show all deliveries counter, we only can display the published deliveries but this behaviour only is for portal website, in backed we want count all deliveries...

image

pedrobaeza commented 3 years ago

Ok, I get the goal, but I'm afraid the implementation is not correct, as you can have portal without website, so you need to create a new field to be used in this part and not to rely on such context.

sergio-teruel commented 3 years ago

Ok... I will re-check so...

github-actions[bot] commented 3 years ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

victoralmau commented 3 years ago

Finally I have added a new field that already filters the records published on the website. If this change is correct, we will add it in v14 as well. What do you think about it?

pedrobaeza commented 3 years ago

/ocabot merge minor

OCA-git-bot commented 3 years ago

On my way to merge this fine PR! Prepared branch 13.0-ocabot-merge-pr-343-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot commented 3 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 3 years ago

Congratulations, your PR was merged at 68b42ed7d769e7d857c9e71236e3bdb1051bb1b7. Thanks a lot for contributing to OCA. ❤️