[15.0][IMP] resource_booking: No create/unlink call if nothing to do

OCA / calendar

GNU Affero General Public License v3.0

24 stars 95 forks source link

[15.0][IMP] resource_booking: No create/unlink call if nothing to do #113

Closed pedrobaeza closed 10 months ago

pedrobaeza commented 10 months ago

Depending on how the create/unlink overrides are programmed, there can be overheads or blocking things when calling unconditionally these methods, even with an empty list, so let's only call them when there is really something to delete or to create.

This has been discovered as google_calendar module is calling Google API on calendar event create (although vals_list being empty), and due to an error with Google API right now, I was not able to create a draft resource booking.

@Tecnativa

pedrobaeza commented 10 months ago

/ocabot merge patch

OCA-git-bot commented 10 months ago

On my way to merge this fine PR! Prepared branch 15.0-ocabot-merge-pr-113-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 10 months ago

Congratulations, your PR was merged at 448f05187f08a0bb32bb0a70d323a832a7568eca. Thanks a lot for contributing to OCA. ❤️