OCA / calendar

GNU Affero General Public License v3.0
24 stars 94 forks source link

[15.0][IMP] resource_booking: New activity type for resource booking #114

Closed carolinafernandez-tecnativa closed 8 months ago

carolinafernandez-tecnativa commented 10 months ago

Add new activity type "Resource booking", and when chosen, it takes us to a draft resource booking, where we can define the necessary data. When the appointment is agreed, then the system will create the mail.activity linked to the calendar event generated the reservation booking.

@Tecnativa TT47152

@pedrobaeza @pilarvargas-tecnativa

OCA-git-bot commented 10 months ago

Hi @pedrobaeza, some modules you are maintaining are being modified, check this out!

carolinafernandez-tecnativa commented 10 months ago

Several comments after trying on runboat:

  • The mail activity can be created in a day far in the future while the resource booking (RB) is not yet scheduled.
  • Once the RB is scheduled, the date of the activity should be synchronized.
  • If the RB is cancelled, the activity should be removed.

Hi @pedrobaeza , I have checked your comments.

See this example:

1- Created Resource booking for tomorrow for this contact (2024-01-17):

image

2- Change start date for Resource booking to 2024-01-18

image

3- Go to the activity and date is updated:

image

4- Go to Resource booking and cancel it, activity dissapears:

image

image image
pedrobaeza commented 10 months ago

Try the same without putting immediately the scheduled date on the resource booking, but saving it in "draft" state (you have to go to list view instead of the calendar one). You will see that once you schedule it, the activity is not correctly "rescheduled". And please read the rest of my comment.

pedrobaeza commented 8 months ago

Some fine-tuning still pending:

@victoralmau can you resume this work to finish this?

victoralmau commented 8 months ago

Changes done.

pedrobaeza commented 8 months ago

After scheduling (in 2 steps) the resource booking in http://oca-calendar-15-0-pr114-a7a1af9762b1.runboat.odoo-community.org, it still puts the incorrect deadline:

imagen

And another thing: please add "Re-schedule" button in the activity the same as in meetings.

victoralmau commented 8 months ago

Changes done.

OCA-git-bot commented 8 months ago

This PR looks fantastic, let's merge it! Prepared branch 15.0-ocabot-merge-pr-114-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot commented 8 months ago

Congratulations, your PR was merged at edb4707c620b0afebe6d83b74a81331e800e4753. Thanks a lot for contributing to OCA. ❤️