search

OCA / calendar

GNU Affero General Public License v3.0
24 stars 95 forks source link

[13.0][FIX] resource_booking: remove test dependency from manifest #98

Closed LoisRForgeFlow closed 1 year ago

LoisRForgeFlow commented 1 year ago

I think test dependencies should not be included in the manifest, otherwise it is forcing to install them in production environments where it is not really needed.

OCA-git-bot commented 1 year ago

Hi @Yajo, some modules you are maintaining are being modified, check this out!

yajo commented 1 year ago

I think the opposite. We don't have a place where to record non-production dependencies. So if there's no other place, better one than none.

LoisRForgeFlow commented 1 year ago

I guess it is a matter of taste and your opinion is more important as original author. Thanks for reviewing, great module BTW!

pedrobaeza commented 1 year ago

The ideal is to have an extra manifest key external_dependencies_tests or similar for this, and be parsed by OCA tools to put test_requirements.txt. The good news is that this specific library is already included in Odoo core in upper versions, and no need to put it here.

yajo commented 1 year ago

That'd be nice, yes.