search

OCA / community-data-files

https://odoo-community.org/project/tools-maintainers-30
GNU Affero General Public License v3.0
33 stars 171 forks source link

[IMP] base_bank_from_iban: automatically create banks with schwifty #170

Closed len-foss closed 10 months ago

len-foss commented 1 year ago

Using Schwifty, we can automatically get bank information from a valid IBAN, i.e. BIC, Swift, code, and bank name. This quick POC automatically create banks at creation/write of a bank account.

In practice the current code might be annoying if used on a DB where banks have already been created with incomplete information. I don't have have any relevant experience with that so I'd be interested to know the best approach to that issue. If used on a new DB, it should just simplify neatly the encoding process.

This could also go into an overriding module.

https://schwifty.readthedocs.io/en/latest

pedrobaeza commented 10 months ago

/ocabot merge major

OCA-git-bot commented 10 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-170-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot commented 10 months ago

Congratulations, your PR was merged at d1728b403ae4fa5e496a158a18665bb458369074. Thanks a lot for contributing to OCA. ❤️

ValentinVinagre commented 10 months ago

@pedrobaeza @carlosdauden @len-foss @Abranes Hey, I think that PR is merged with a wrong message in the commit. Could you change it?

pedrobaeza commented 10 months ago

Indeed, I wasn't aware, but I'm afraid now that this can't be changed.

ValentinVinagre commented 10 months ago

Indeed, I wasn't aware, but I'm afraid now that this can't be changed.

the branch is protected and force cannot be used?

pedrobaeza commented 10 months ago

Doing that will screw all the people that have already pulled this branch, forcing them to do a reset, so that's too much to do, and more having passed several weeks since the merge.

ValentinVinagre commented 10 months ago

And a rebert and then commit again with the correct message?

pedrobaeza commented 10 months ago

A more convoluted history... Let's fix this in v17. At the end, the commit is linked to this PR, where there is enough information.