search

OCA / community-data-files

https://odoo-community.org/project/tools-maintainers-30
GNU Affero General Public License v3.0
33 stars 171 forks source link

[FIX] [15.0] base_iso3166 breaking tests if code is False #187

Closed nikolausweingartmair closed 3 months ago

nikolausweingartmair commented 8 months ago

The module currently breaks tests in "delivery_multi_destination".

I added a test if code is False before getattr.

https://github.com/OCA/delivery-carrier/actions/runs/7362481660/job/20040960822?pr=751

Bildschirmfoto 2023-12-30 um 08 20 17

nikolausweingartmair commented 8 months ago

now it should be a clean commit

github-actions[bot] commented 4 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

dreispt commented 3 months ago

/ocabot merge patch

OCA-git-bot commented 3 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-187-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 6bed2071fbb3502b6b47388945f1db50fa90cda1. Thanks a lot for contributing to OCA. ❤️