Closed hailangvn closed 10 months ago
There is one point bugging me. You are including commit from another module:
connector_prestashop
and then delteting the related files. It's a bit messy regarding the git history.
Thanks @leemannd for your review and comment. The last commit, which deletes another module, will be drop after this PR is approved. The purpose of the commit is to have travis green. Let me know if this practice is not good for future use. :)
Thanks @leemannd, @StephaneMangin, @pedrobaeza for your support. I have squashed commits, drop test commit. Please let me know if anything else is needed.
@hailangvn I see that for some reason checks are failing - anything needed to do from your side?
Thanks @ventor-dev for your comment. I will arrange time to work on this.
Hi @hailangvn , thanks for the effort on the #147 that was an awesome PR. Could you do some cleanup in this one like rebasing, checking the test-requirements etc... I'll push on the dependency to check everything is Ok
Thanks @flotho. This has been rebased. Tests are failing because of missing dependency. Also note that I have no time to verify this module with latest connector_prestashop
module.
Hi @hailangvn no problem, I'm also working on this module either so I'll be able to contribute. If you want I can make some PR to your branch so that we'll be able to go as fast as possible
@flotho, sure, I am looking forward for your PR. Thanks a lot.
I am rebasing and also spliting product_brand
from connector_prestashop_catalog_manager
.
Hi @hailangvn thanks to you and the rest of the community for your job done with PS connector modules. I am testing connector_prestashop on a testing environment with PS 1.7.5.1 and a production mysql database, it looks great, so far so good ! The point is that we are interested in this module to manage products, categories and so on in Odoo and then syncrhonize them to PS. Please, would you give us information about the work in progress ? We would be pleased to do functional testing and report back any kind of issues. Thanks in advance.
Hi, @uolaizola thanks for your support. I can also confirm that this code is fully functionnal for a PS >=1.7.x.0 - <1.7.5.0 I think that @hailangvn looks a little overbooked, maybe you could restart with his PR and superseeds this one by referencing his code. This way you'll be able to contribute.
Thanks @uolaizola and @flotho for your comments. Yes, the code could work at the last project I used it, although a little bit long in the past. Now I am splitting model product_brand
from module connector_prestashop_catalog_manager
so the module can work with current connector_prestashop
. It tooks long time to work with historical commits so I decide to stop on that way and rather create new commit to split out. Hope it can be done by end of next two weeks.
Thanks to both of you @flotho and @hailangvn for answering to my comment. We'll start working with this version of connector_prestashop_catalog_manager with the actual dependency to product_brand to test and understand its workflow. We'll appreciate any further information on the development of the module, as I said, we are glad to do this tests, debug and report back any kind of problems. In some point if I am able to contribute with the development I'll know you, but it depends on the schedule of the enterprise that I am working for. Thank you again.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
This depends on below PR.