search

OCA / connector-prestashop

Connect Odoo with Prestashop
GNU Affero General Public License v3.0
91 stars 170 forks source link

[IMP]Force partner type when PS company not set #162

Closed flotho closed 1 year ago

flotho commented 2 years ago

the company field in PS clearly indicates that it shoudl be a company in Odoo. As a counterpart we should consider that if this field is not field, the PS account is a person. This PR propose to force this value so that the general conf/behaviour in Odoo will not be the default behaviour for the connector.

flotho commented 2 years ago

Hi @jesusVMayor , as a complement of your PR, I would appreciate a reveiw on this one. Regards

flotho commented 2 years ago

Hi @saxomanu @gaelTorrecillas @rousseldenis , a small review on this would be appreciated. regards

flotho commented 2 years ago

Hi @florian-dacosta , you're totally right. Except the fact that some additionnal default values could be added for customer having multiple activities like PSO and/or B2B. Forcing by code the default value for this "channel" is a way to preserve consistency of the datas coming from PS.

flotho commented 2 years ago

ping @hailangvn @jesusVMayor any chance to be revbiewed ?

OCA-git-bot commented 2 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

flotho commented 2 years ago

ping @OCA/connector-prestashop-maintainers any chance to be merged ?

bguillot commented 1 year ago

Thank you:

/ocabot merge patch

OCA-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 14.0-ocabot-merge-pr-162-by-bguillot-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

@bguillot your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-162-by-bguillot-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

bguillot commented 1 year ago

/ocabot merge patch

OCA-git-bot commented 1 year ago

What a great day to merge this nice PR. Let's do it! Prepared branch 14.0-ocabot-merge-pr-162-by-bguillot-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 2b00f5a5f31e8524f56ea72816964ef104bce5ff. Thanks a lot for contributing to OCA. ❤️