search

OCA / connector-telephony

Odoo modules for telephony integration
GNU Affero General Public License v3.0
151 stars 293 forks source link

[12.0][MIG] - base_sms_client migration to 12.0 #209

Closed sbejaoui closed 2 years ago

sbejaoui commented 4 years ago

cc/ @gva-acsone

LuceEasyPme commented 4 years ago

Hello @sbejaoui It would be good to have these 3 checks in wizards/mass_sms.py, on the send function : sms._check_gateway_method() sms._check_gateway_permission() sms._check_sms_length()

The problem that we have, is that we can click on "send" in the wizard, event thought the message is too long, and if we do not check the message list on technical, we don't know that the message was not actually sent.

Thanks,

cc @cvinh

LuceEasyPme commented 4 years ago

Here is my PR on @sbejaoui repo, for the changes I suggested: https://github.com/acsone/connector-telephony/pull/1

cvinh commented 4 years ago

Hello Finally, we think that it's better to use the core sms module provided by Odoo CE since v12 We use it in production with the ovh endpoint module developped by @fmdl So we are not going to work anymore on that module Best regards

sebastienbeau commented 4 years ago

@cvinh @sbejaoui @LuceEasyPme maybe you can be interested by this PR https://github.com/OCA/connector-telephony/pull/217 I take a look to the @fmdl module but I prefers the api http2sms (really simple for the end user to configure and with several option on ovh interface quota, alert ...).

cvinh commented 4 years ago

@sebastienbeau yes we like it too for same reasons, moreover, in OVH API there is a security hole as we can use the user account without password Thank you !

github-actions[bot] commented 2 years ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.