12.0 mig base sms client

OCA / connector-telephony

Odoo modules for telephony integration

GNU Affero General Public License v3.0

151 stars 293 forks source link

12.0 mig base sms client #210

Closed cvinh closed 4 years ago

cvinh commented 4 years ago

@sbejaoui we did not see that you were working on the migration of this module... our bad.. By the way we found 2 issues that we fixed in that PR. Could you have a look and include then in your PR ?

sbejaoui commented 4 years ago

Hi @cvinh ,

I will consider the fixes in my PR. From my side, I made some fixes too:

Remove usless keychain dependency
remove explicit cr.commit
set sms company based on user company

I am working on some improvement of the module:

Properly define sms templates
Integrate sms templates in ir.cron

sbejaoui commented 4 years ago

I added your fix to #209 , we can close this one and follow-up with me on the other one