[IMP] base_phone : (refactoring) remove controller

OCA / connector-telephony

Odoo modules for telephony integration

GNU Affero General Public License v3.0

151 stars 293 forks source link

[IMP] base_phone : (refactoring) remove controller #215

Closed luffah closed 4 years ago

luffah commented 4 years ago

Hello,

here is just a proposal to simplify module structure by directly call click2dial function passing phone_number and context in the function call (js side), instead of using a controller for that.

alexis-via commented 4 years ago

Seems a good idea. Did you test that code in real life with an asterisk server ?

luffah commented 4 years ago

Implicitly : yes. (the -customer- testing team says me it is ok, and since i have no personal asterisk server ... i have no other choice to trust em)

They use this branch https://github.com/osiell/connector-telephony/tree/12.0-back-to-orig (fixing https://github.com/OCA/connector-telephony/issues/214) based on the current proposed change, that i will propose once this one is (or not) merged.

alexis-via commented 4 years ago

Thanks for your contribution !