[FIX][12.0] Open caller button bug

[ecino]

This is a strange bug that appears when single quotes are used inside a double quote translated string. The error message: Uncaught Error: [_.sprintf] expecting number but found string is triggered as if it modified the way formats behave. Using an escaped double quote is not a solution neither because it appears as a double quote with a preceding backslash in the resulting string. Here are a few options to solve this issue:

• Remove the single quotes (chosen solution)
• Add a white space after the first and before the second single quotes
• Add a second single quote either before, after or only one of the two possibilities
• Use an escaped double quote (\") but the backslash appears in the resulting string It may be an issue that also appears on the official OCA repository as well but it seems strange that nobody figured that this problem exists. Also, this PR avoids the exception that is thrown, but it does not propose a solution to still be able to use a quote inside a formatted string.

It fixes also an issue where you don't get the correct phonecalls when you go from a partner into his opportunities and then in the phonecalls, because the active_id is then associated to a partner and not an opportunity.

[dreispt]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR! Prepared branch 12.0-ocabot-merge-pr-216-by-dreispt-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at ad72092e3d69f2eecb71e8f9b713f9acc33df50e. Thanks a lot for contributing to OCA. ❤️