search

OCA / connector-telephony

Odoo modules for telephony integration
GNU Affero General Public License v3.0
150 stars 293 forks source link

asterisk_click2dial: AMI -> ARI #276

Closed alexis-via closed 1 year ago

alexis-via commented 1 year ago

For the module asterisk_click2dial, we should switch from AMI to ARI. That will remove dependency on py-Asterisk and we'll use lib requests to perform the ARI requests.

If you disagree with this change, please comment and explain.

alexis-via commented 1 year ago

I developped a proto on my laptop for click2dial ; it works well, and I think it simplifies the code. I still need to update the code of _get_calling_number()

alexis-via commented 1 year ago

I have a first working version with _get_calling_number(). So I can now confirm that AMI can be fully replaced by ARI in the module asterisk_click2dial while keeping all the features of the module.

alexis-via commented 1 year ago

I now need to cleanup the code, commit and make a PR. Probably this week-end.

alex2grad commented 1 year ago

I willing to test if the PR is ready?

github-actions[bot] commented 1 year ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

alexis-via commented 1 year ago

It has already been merged in this PR https://github.com/OCA/connector-telephony/pull/292