search

OCA / connector-telephony

Odoo modules for telephony integration
GNU Affero General Public License v3.0
150 stars 293 forks source link

[16.0][MIG] base_phone: Migration to 16.0 #296

Closed nguyenminhchien closed 1 year ago

nguyenminhchien commented 1 year ago

This PR replaces https://github.com/OCA/connector-telephony/pull/294

StephaneMangin commented 1 year ago

Please anonymise the test datas

mmequignon commented 1 year ago

Hello, I commented on the previous pr: https://github.com/OCA/connector-telephony/pull/294#discussion_r1123058362

This mixin looks useless to me, since odoo.addons.phone_validation.tools.phone_format has been introduced. Therefore, this whole module would be useless as well. I think we should use it in https://github.com/OCA/connector-telephony/pull/297 and drop this base_phone module if possible.

nguyenminhchien commented 1 year ago

Please anonymise the test datas

@StephaneMangin : updated, please review.

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖