[16.0][MIG] hr_phone: Migration to 16.0

OCA / connector-telephony

Odoo modules for telephony integration

GNU Affero General Public License v3.0

150 stars 295 forks source link

[16.0][MIG] hr_phone: Migration to 16.0 #297

Closed nguyenminhchien closed 11 months ago

nguyenminhchien commented 1 year ago

This PR replaces https://github.com/OCA/connector-telephony/pull/295 Depend:

https://github.com/OCA/connector-telephony/pull/296

StephaneMangin commented 1 year ago

For the PR dependency, please take in account this comment https://github.com/OCA/edi/pull/724#issuecomment-1461765822

mmequignon commented 1 year ago

~~Could you please address this comment? https://github.com/OCA/connector-telephony/pull/296#issuecomment-1543517072~~

nilshamerlinck commented 1 year ago

Hello @mmequignon

your remark in previous PR has been taken into account: the old mixin has been removed in this PR and the code relies on odoo native's _phone_format that uses odoo.addons.phone_validation.tools.phone_format indeed
base_phone comes with some other features (wizards, widget), and is needed for other modules such crm_phone
that said if you think it's worth it, we will work on a new PR for an hr_phone that doesn't depend on base_phone anymore

mmequignon commented 1 year ago

Hello @mmequignon

* your remark in previous PR has been taken into account: the old mixin has been removed in this PR and the code relies on odoo native's [`_phone_format`](https://github.com/odoo/odoo/blob/16.0/addons/phone_validation/models/res_partner.py#L21) that uses `odoo.addons.phone_validation.tools.phone_format` indeed

* `base_phone` comes with some other features (wizards, widget), and is needed for other modules such `crm_phone`

* that said if you think it's worth it, we will work on a new PR for an `hr_phone` that doesn't depend on `base_phone` anymore

my bad, I thought the previous pr has just been reopened. I'll update my review, please ignore my previous comment. Sorry for the noise!

github-actions[bot] commented 1 year ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.