search

OCA / connector-woocommerce

GNU Affero General Public License v3.0
53 stars 106 forks source link

Changes done in the all the appropriate model files according to the … #30

Closed techspawn1 closed 8 years ago

techspawn1 commented 8 years ago

…new version of api available in woocommerce version 2.6.4

Fully compatible with woocommerce version(2.4.6) Modified the process of import to get the list of the data Modified the date time format in WOO_DATETIME_FORMAT

oca-clabot commented 8 years ago

Hey @techspawn1, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet. You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla Here is a list of the users:

Appreciation of efforts, OCA CLAbot

parthivgls commented 8 years ago

Not possible to merge as at a first glance original author's copyright is blatantly removed and replaced.

parthivgls commented 8 years ago

closing this PR as to me is just for own benefit purpose instead of working as per community standards.

techspawn1 commented 8 years ago

@parthivgls As it was our first commit and it was not meant for own benefits. We just wanted to enhance and add extra compatibility for the newer version of woo commerce i.e 2.6.4 and contribute it to the community. Can you please advice best possible way to do it and also get credits without impacting original copy rights.

pedrobaeza commented 8 years ago

You should add copyright lines instead of replacing in the files (and not all), and only in the affected.

You should also take into account if the same backend is compatible for all versions or only the newer ones. If not, you need to create two backends.