OCA / contract

GNU Affero General Public License v3.0
170 stars 522 forks source link

[15.0][FIX] contract: report translations & change structure #1072

Closed peluko00 closed 5 months ago

peluko00 commented 5 months ago

Problem to solve: Go to Sales -> Orders -> Contracts and try to print a contract. Normally when you print a contract the default language of that one bases on customer language but not works in that report. Example: Your default language is Spanish and your customer's default language is English Try to print the report and you see that the report prints in Spanish and not in English. I changed the structure because i'm base of the report of an invoice from the odoo's core structure(see more in the links below):

contract_report_failed.webm

contract_report_works.webm

pedrobaeza commented 5 months ago

What about the screenshots?

peluko00 commented 5 months ago

Fixed Module report

cc https://github.com/APSL 154015

@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall please review

peluko00 commented 5 months ago

What about the screenshots?

Just upload two videos, one failing and the other with the current pr

peluko00 commented 5 months ago

Ready for merge @pedrobaeza ?

pedrobaeza commented 5 months ago

Second review missing

peluko00 commented 5 months ago

Second review missing

Second review done

pedrobaeza commented 5 months ago

/ocabot merge minor

OCA-git-bot commented 5 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-1072-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at 33fcb5e541cd56709be96c0231ae61336cd5432d. Thanks a lot for contributing to OCA. ❤️