[IMP] cooperator: Refactor cooperative.membership preparation code

carmenbianca commented 10 months ago

There were two places where there was broadly the same workflow; set expected values on a partner's cooperative.membership after giving them a membership.

That code is now in one place, and does the following as per the docstring:

member is set to True and old_member is set to False.
A cooperator register number is assigned if one did not yet exist.
A user is created if one did not yet exist.

This desperately needs tests.

I also wrote an optional convenience functionality into res.partner's get_cooperative_membership: create one if it doesn't yet exist.

Internal task: https://gestion.coopiteasy.be/web#view_type=form&model=project.task&id=9652&active_id=9652&menu_id=

carmenbianca commented 8 months ago

/ocabot merge patch

OCA-git-bot commented 8 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-101-by-carmenbianca-bump-patch, awaiting test results.

OCA-git-bot commented 8 months ago

Congratulations, your PR was merged at 36cbd0252e3d833449df30315829fa861894ed2b. Thanks a lot for contributing to OCA. ❤️

OCA / cooperative

[IMP] cooperator: Refactor cooperative.membership preparation code #101