[16.0][IMP] tax shelter : UX improvements

OCA / cooperative

GNU Affero General Public License v3.0

11 stars 22 forks source link

[16.0][IMP] tax shelter : UX improvements #113

Closed victor-champonnois closed 8 months ago

victor-champonnois commented 9 months ago

Issue: As soon as the declaration is computed, all lines of the declaration have a “draft” status. The non-eligible lines are in the same state as the others. The same happens upon validation. It is only when sending the certificate that the status of these lines becomes either "sent" or "not eligible".

Proposal:

compute the state no_eligible on creation of the certificates instances.
mutes the certificate that are not eligible in the declaration form view

internal task : https://gestion.coopiteasy.be/web#action=475&active_id=524&model=project.task&view_type=kanban&menu_id=536 @huguesdk

victor-champonnois commented 9 months ago

@huguesdk thank you for the review

I added your suggestions
added a test
renamed some buttons to clarify the sending process
improved the interface of the declaration form. We let the user sets the date, and then the fiscal and declaration years are computed. Also set the date by default based on the previous year.

victor-champonnois commented 8 months ago

@huguesdk all changes done !

OCA-git-bot commented 8 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

huguesdk commented 8 months ago

/ocabot merge nobump

OCA-git-bot commented 8 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-113-by-huguesdk-bump-nobump, awaiting test results.

OCA-git-bot commented 8 months ago

Congratulations, your PR was merged at ee82046635357667d7af6b944dbe5af37bed61a1. Thanks a lot for contributing to OCA. ❤️