OCA / cooperative

GNU Affero General Public License v3.0
11 stars 22 forks source link

12.0 add l10n be cooperator national number #56

Closed victor-champonnois closed 1 year ago

victor-champonnois commented 1 year ago

Depends on unmerged PR https://github.com/OCA/l10n-belgium/pull/177

victor-champonnois commented 1 year ago

@robinkeunen PR moved to oca/cooperative

victor-champonnois commented 1 year ago

@robinkeunen Modules moved to OCA/cooperative and ready for review.

robinkeunen commented 1 year ago

@victor-champonnois yes, you should add the test-requirements if the module remains here. Although - I'm sorry - you missed my last comment on the other PR :

before moving: check this conversation https://github.com/OCA/cooperative/pull/51#issuecomment-1420832739

=> @huguesdk does not agree we should bring all localizations back here. Cesar will ask the community.

victor-champonnois commented 1 year ago

@robinkeunen Oupsy, it's ok, it's not difficult to revert

victor-champonnois commented 1 year ago

@remytms I ran black manually. (I think black is not used by precommit), It wanted to also reformat cooperator and other modules. I commited the reformats to the current modules.

victor-champonnois commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

Sorry @victor-champonnois you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

robinkeunen commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

What a great day to merge this nice PR. Let's do it! Prepared branch 12.0-ocabot-merge-pr-56-by-robinkeunen-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at c662097e2a1cd3a972bad4904b5fc40557c50bb3. Thanks a lot for contributing to OCA. ❤️